Lære Review and Respond to Feedback | Making and Reviewing Contributions

Code reviews are a central part of open source collaboration. They help maintain high standards, catch bugs early, and ensure that contributions align with the project's goals. Giving and receiving feedback constructively is essential: when you review code, focus on clarity, maintainability, and correctness, offering suggestions rather than demands. When you receive feedback, approach it with an open mind and a willingness to learn—remember that comments are about the code, not about you personally. This process not only improves the quality of the project but also helps you grow as a developer and a collaborator.


              1234567891011121314151617
            
# Suppose you have opened a pull request and a reviewer suggests changes.
# You can address this feedback by updating your PR in one of two ways.

# 1. Amending the last commit (if you want to edit your latest commit)
git add changed_file.py
git commit --amend

# 2. Creating a new commit with your changes
git add changed_file.py
git commit -m "Address reviewer feedback: fix bug in data processing"

# Then, push your changes to update the pull request.
# If you amended your commit, force-push is required:
git push --force

# If you added a new commit, a regular push is enough:
git push

When responding to review comments on your pull request, reply to each suggestion or question directly in the code review discussion. Be clear about what changes you made or why you chose a particular approach. If you have addressed a comment, mark the conversation as resolved—this helps reviewers track progress and keeps the discussion organized. Engaging respectfully and transparently with reviewers builds trust and shows that you value their input.

Var alt klart?

Tak for dine kommentarer!

Sektion 3. Kapitel 2

Spørg AI

Spørg om hvad som helst eller prøv et af de foreslåede spørgsmål for at starte vores chat

Stryg for at vise menuen


              1234567891011121314151617
            
# Suppose you have opened a pull request and a reviewer suggests changes.
# You can address this feedback by updating your PR in one of two ways.

# 1. Amending the last commit (if you want to edit your latest commit)
git add changed_file.py
git commit --amend

# 2. Creating a new commit with your changes
git add changed_file.py
git commit -m "Address reviewer feedback: fix bug in data processing"

# Then, push your changes to update the pull request.
# If you amended your commit, force-push is required:
git push --force

# If you added a new commit, a regular push is enough:
git push

Var alt klart?

Tak for dine kommentarer!

Sektion 3. Kapitel 2